[Bug 1698224] Review Request: pyqtwebengine - Python bindings for QtWebEngine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1698224

Miro Hrončok <mhroncok@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |mhroncok@xxxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |mhroncok@xxxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
- PyQtWebEngine is python bindings for QtWebEngine -> PyQtWebEngine is Python
bindings for QtWebEngine
- The source URL gives error 404
- Technically you should BR gcc-c++ and not assume it will be pulled by some
devel package
- spec and SRPM differ in %sip_ver

I suggest using the new flags macros, also available on EPEL 6:

https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/buildflags.md
https://src.fedoraproject.org/rpms/epel-rpm-macros/blob/el6/f/macros.zzz-epel

%{?__global_ldflags} -> %{build_ldflags}
%{optflags} -> %{build_cflags} and %{build_cxxflags}

rpmlint considerable problems:
pyqtwebengine.src:17: E: buildarch-instead-of-exclusivearch-tag
%{?qt5_qtwebengine_arches}
pyqtwebengine.src: W: invalid-url Source0:
https://www.riverbankcomputing.com/static/Downloads/PyQtWebEngine/PyQtWebEngine_gpl-5.12.1.tar.gz
HTTP Error 404: Not Found

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux