https://bugzilla.redhat.com/show_bug.cgi?id=1377762 --- Comment #12 from Carl George <carl@george.computer> --- No worries, you're doing great so far. Thanks for making those adjustments. It doesn't look like the tests are actually getting run. From your scratch build log: + make check Making check in src make[1]: Entering directory '/builddir/build/BUILD/opendht-1.8.2/src' make[1]: Nothing to be done for 'check'. make[1]: Leaving directory '/builddir/build/BUILD/opendht-1.8.2/src' Making check in tools make[1]: Entering directory '/builddir/build/BUILD/opendht-1.8.2/tools' make[1]: Nothing to be done for 'check'. make[1]: Leaving directory '/builddir/build/BUILD/opendht-1.8.2/tools' Making check in python make[1]: Entering directory '/builddir/build/BUILD/opendht-1.8.2/python' make[1]: Nothing to be done for 'check'. make[1]: Leaving directory '/builddir/build/BUILD/opendht-1.8.2/python' make[1]: Entering directory '/builddir/build/BUILD/opendht-1.8.2' make[1]: Leaving directory '/builddir/build/BUILD/opendht-1.8.2' Upstream says you'll need pkgconfig(cppunit) for the tests [0], but I'm not sure if that being present will by itself enable the tests. I'm not an expert on autoconf stuff, but if I understand that configure.ac right, I think running configure with `--enable-tests` will turn it on. Try that and see if the %check output looks different. One more small thing I noticed, the license headers in the source say "either version 3 of the License, or (at your option) any later version", so the License field needs to be GPLv3+. Since you included a comment about EPEL7, I thought I'd mention that upstream claims to need at least GCC 5.2. That will be a problem a EL7 only has 4.8.5. I've heard that EPEL7 packages can now use devtoolset to get a newer compiler, but I don't know much about the specifics. On that note, you may want to include the minimum versions of the build requirements listed in the README. [0]: https://github.com/savoirfairelinux/opendht/blob/1.8.2/configure.ac#L123 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
