[Bug 1690046] Review Request: Charliecloud - unprivileged container runtime

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1690046



--- Comment #7 from Dave Love <dave.love@xxxxxxxxxxxxxxxx> ---
As far as doc files are concerned, I think you should consider the version
you're packaging, rather than a future one, and the source built for me, so
there doesn't seem to be a reason not to include it.  (If you mean you won't
ship the doc source eventually, that would make it non-free by Debian
standards.)

I'm not sure what the problem is with shipping small example files as part of
the documentation, which is what's normally done, though I don't think there's
policy on it.  If tests run without docker, can you run them in %check?  (I
don't know if the builders have the namespace support turned on, and should
probably check; if not, perhaps it could be turned on if it helps this sort of
package.)

Creating the READMEs should happen under %install, not %check.  I'll check more
closely later.

You can't get the package into Fedora without being a maintainer, and you
probably need to do some informal reviews before someone will sponsor you, so
yes, you should be working on that.  See the relevant links under 
https://fedoraproject.org/wiki/Package_Review_Process
(It would probably have been better for me to submit packaging and make you
co-maintainer initially, but we'll have to work from here.)

Hope that helps for the moment.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux