[Bug 1658153] Review Request: wdune - wdune (white_dune) is a graphical VRML97/X3D editor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1658153



--- Comment #81 from Petr Menšík <pemensik@xxxxxxxxxx> ---
(In reply to J. Scheurich from comment #79)
> 
> Added human animation to opengl example
>
Nice. Please lets focus on required features. Examples are nice to have, but we
should make the package ready for inclusion, so you can commit you changes
visible to users, not just me.

> > Requires: %{name}%{?_isa} = %{name}-%{version}
> 
> I failed to include this. The thing would require two "-" characters to
> work, which is not accepted.
> Instead i added 
> 
> Recommends: wdune
Unfortunately, this is not ok. Can you paste what message it printed with
Requires? rpmspec -P wdune.spec might help you ensure file is correct.

Recommends does not force that package to be installed with examples. Unless
examples includes its own license file, which I think should not be necessary,
it must Require package with license file, also with the same version.

Ok, got it, my fault, I am sorry. Correct syntax is:
Requires: %{name}%{?_isa} = %{version}-%{release}

Please add this to both examples and docs subpackages.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux