[Bug 1662572] Review Request: python-aiohttp-socks - SOCKS proxy connector for aiohttp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1662572



--- Comment #11 from Igor Gnatenko <i.gnatenko.brain@xxxxxxxxx> ---
> - aiohttp is a requirement
>  https://github.com/romis2012/aiohttp-socks/blob/master/setup.py

It is generated automatically, nothing to do.

> - RPMlint issues (see output)

I've fixed README.md one.

> - Tests are available but no %check section

They are not. Not on PyPI tarball.

> 2. Package Naming

Fixed.

> 3. Package Dependencies

It is not necessary in F30+. But since we need to build it in F29, I put
necessary line.

> 4. Provides

Fixed.

> 5. Source

Right now, there is one source... So no need to fix anything.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux