[Bug 1692070] Review Request: python-pystemd - A thin Cython-based wrapper on top of libsystemd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1692070

Neal Gompa <ngompa13@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |ASSIGNED



--- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> ---
ON_QA status is for Bodhi...


> - Changelog format needs to be updated slightly; see
>   - https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs
>

This changelog format is compatible in all current Fedora releases.

It's being used in other packages now too:
https://src.fedoraproject.org/rpms/libsolv/blob/master/f/libsolv.spec#_304

It does not work on EL7, but this package is literally not compatible with EL7
systemd. I can change it if you insist...

> - python3-%{pypi_name} package entry is missing Requires: references.
>   I presume you will require systemd and/or dbus to be availble?

The runtime dependencies will be autogenerated through the Python dependency
generator or the regular library dependency generator.

> - you got a lot of /usr/bin/env python3 references in files that are clearly
>   not meant to be executable.  Removing these should clear up a good number of
>   the rpmlint checks identified at the bottom

I'll clean those up.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux