https://bugzilla.redhat.com/show_bug.cgi?id=1696874 --- Comment #5 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- (In reply to Carl George from comment #4) > While verifying the pkgconfig provides, I re-read the guidelines for this > [0], and noticed that it only applies when the software is using pkg-config > to locate the library. In this case most of the libraries are detected by > AC_CHECK_LIB [1], with the exception of dbus, which is detected with > PKG_CHECK_MODULES. As such the only change I made was: > > -BuildRequires: dbus-devel > +BuildRequires: pkgconfig(dbus-1) > > > [0]: > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > PkgConfigBuildRequires/ > [1]: https://www.gnu.org/software/autoconf/manual/autoconf.html#Libraries I kind of disagree with this. This is true that the guidelines say: "Fedora packages which use pkg-config to build against a library" but the rationale expressed below: "Where package names change, and/or a required pkgconfig module is later provided by a different package, these hard-coded dependencies break." is true even if the package doesn't use it internally. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
