https://bugzilla.redhat.com/show_bug.cgi?id=1684956 Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hiwkby@xxxxxxxxx --- Comment #2 from Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> --- Hello Robert-André, please read this for you reference. Summary ======= 1. rpmlint results 2. Koji scratch build succeeded 3. Others Details ======= 1. rpmlint results ------------------ One error and one warning on the source rpm and 11 warnings on the binary rpms. Here are the rpmlint results:: $ rpmlint /home/vagrant/rpmbuild/RPMS/noarch/golang-github-anacrolix-dms-devel-0-0.1.20190304git8af4925.fc29.noarch.rpm golang-github-anacrolix-dms-devel.noarch: W: spelling-error Summary(en_US) transcoding -> trans coding, trans-coding, transcending golang-github-anacrolix-dms-devel.noarch: W: spelling-error %description -l en_US transcoded -> trans coded, trans-coded, transcended golang-github-anacrolix-dms-devel.noarch: W: spelling-error %description -l en_US ffprobe -> ff probe, ff-probe, probe golang-github-anacrolix-dms-devel.noarch: W: spelling-error %description -l en_US avprobe -> av probe, av-probe, probe golang-github-anacrolix-dms-devel.noarch: W: spelling-error %description -l en_US bitrate -> nitrate, bit rate, bit-rate golang-github-anacrolix-dms-devel.noarch: W: spelling-error %description -l en_US ffmpeg -> MPEG golang-github-anacrolix-dms-devel.noarch: W: spelling-error %description -l en_US avconv -> concave golang-github-anacrolix-dms-devel.noarch: W: spelling-error %description -l en_US transoding -> transcending, transposing, transporting golang-github-anacrolix-dms-devel.noarch: W: spelling-error %description -l en_US ffmpegthumbnailer -> thumbnail golang-github-anacrolix-dms-devel.noarch: W: no-documentation golang-github-anacrolix-dms-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/anacrolix/dms/.goipath 1 packages and 0 specfiles checked; 0 errors, 11 warnings. $ rpmlint /home/vagrant/rpmbuild/SRPMS/golang-github-anacrolix-dms-0-0.1.20190304git8af4925.fc29.src.rpm golang-github-anacrolix-dms.src: W: spelling-error Summary(en_US) transcoding -> trans coding, trans-coding, transcending golang-github-anacrolix-dms.src: W: spelling-error %description -l en_US transcoded -> trans coded, trans-coded, transcended golang-github-anacrolix-dms.src: W: spelling-error %description -l en_US ffprobe -> ff probe, ff-probe, probe golang-github-anacrolix-dms.src: W: spelling-error %description -l en_US avprobe -> av probe, av-probe, probe golang-github-anacrolix-dms.src: W: spelling-error %description -l en_US bitrate -> nitrate, bit rate, bit-rate golang-github-anacrolix-dms.src: W: spelling-error %description -l en_US ffmpeg -> MPEG golang-github-anacrolix-dms.src: W: spelling-error %description -l en_US avconv -> concave golang-github-anacrolix-dms.src: W: spelling-error %description -l en_US transoding -> transcending, transposing, transporting golang-github-anacrolix-dms.src: W: spelling-error %description -l en_US ffmpegthumbnailer -> thumbnail golang-github-anacrolix-dms.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 10 warnings. $ rpmlint golang-github-anacrolix-dms.spec golang-github-anacrolix-dms.spec: W: no-%build-section 0 packages and 1 specfiles checked; 0 errors, 1 warnings. My review on the result above is as followings. 1.1. golang-github-anacrolix-dms-devel.noarch: W: no-documentation You should include any relevant documentation in the source distribution. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation 2. Koji scratch build succeeded -------------------------------- Here is the result of "koji build --scratch rawhide golang-github-anacrolix-dms-0-0.1.20190304git8af4925.fc31.src.rpm". https://koji.fedoraproject.org/koji/taskinfo?taskID=34009889 3. Others ---------- This package depends on the github.com/mattn/go-gtk/gdk, which is reviewed in https://bugzilla.redhat.com/show_bug.cgi?id=1692376 I think the spec file should be changed like the following:: $ diff -c golang-github-anacrolix-dms.spec.orig golang-github-anacrolix-dms.spec *** golang-github-anacrolix-dms.spec.orig 2019-04-06 23:39:40.612938451 +0000 --- golang-github-anacrolix-dms.spec 2019-04-06 23:40:01.253782349 +0000 *************** *** 42,47 **** --- 42,48 ---- %package devel Summary: %{summary} BuildArch: noarch + Requires: golang(github.com/mattn/go-gtk) %description devel %{common_description} Here is the log that I tried to install this package in my environment:: $ sudo rpm -ivh ~/rpmbuild/RPMS/noarch/golang-github-anacrolix-dms-devel-0-0.1.20190304git8af4925.fc29.noarch.rpm error: Failed dependencies: golang(github.com/mattn/go-gtk/gdk) is needed by golang-github-anacrolix-dms-devel-0-0.1.20190304git8af4925.fc29.noarch golang(github.com/mattn/go-gtk/gtk) is needed by golang-github-anacrolix-dms-devel-0-0.1.20190304git8af4925.fc29.noarch Thanks in advance, Hirotaka Wakabayashi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
