https://bugzilla.redhat.com/show_bug.cgi?id=1695526 --- Comment #2 from Georg Sauthoff <fedora@xxxxxxxx> --- (In reply to dan.cermak from comment #1) > Looks good overall, I only have the following suggestions: > > - Please use " instead of “, the spec file should be plain ASCII when > possible Is this in the guidelines, couldn't find it there. Changed it anyways. > - The packages python files come with odd shebangs (see rpmlint output), > consider removing them and notify upstream I removed those. > - The individual files of the package indicate that they are GPLv3+ > licencensed, instead of AGPLv3. Is that intended? It's only one file (the command line interface) which is GPLv3+. The AGPLv3+ allows such mixing and since the AGPL is more strict the effective license is AGPLv3+. Yes, it's intended. > - Consider running a scratch build on all supported Fedora architectures Since this is all high-level Python-only code it's unlikely that the packaging fails on other architectures. Spec URL: https://copr-be.cloud.fedoraproject.org/results/gsauthof/fedora/fedora-rawhide-x86_64/00878448-python-inema/python-inema.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/gsauthof/fedora/fedora-rawhide-x86_64/00878448-python-inema/python3-inema-0.6-1.fc31.noarch.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
