https://bugzilla.redhat.com/show_bug.cgi?id=1695362 --- Comment #6 from Georg Sauthoff <fedora@xxxxxxxx> --- Ok, just a side node: using a more stable URL has advantages for review purposes - e.g. https://pagure.io/python-metaextract/raw/d7cce8e350cb5a4a979f2c1329b52259391dc19a/f/python-metaextract.spec or a link into a specific copr build for that .spec, as well. This package uses an archive from the project's github repo instead of one from the project's PyPi package - the latter one doesn't include the test cases. There are some warnings from fedora-review you can fix: ===== MUST items ===== Generic: [ ]: License file installed when any subpackage combination is installed. => i.e. the doc package doesn't seem to include the license file/a license section [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. => the doc package is perhaps overkill in this case as it isn't much more than a very short readme [ ]: Changelog in prescribed format. => see below Rpmlint ------- Checking: python3-metaextract-1.0.5-1.fc29.noarch.rpm python-metaextract-doc-1.0.5-1.fc29.noarch.rpm python-metaextract-1.0.5-1.fc29.src.rpm python3-metaextract.noarch: W: summary-not-capitalized C get metadata for python modules python3-metaextract.noarch: W: no-version-in-last-changelog python3-metaextract.noarch: W: no-manual-page-for-binary metaextract python-metaextract-doc.noarch: W: no-version-in-last-changelog python-metaextract.src: W: summary-not-capitalized C get metadata for python modules python-metaextract.src: W: no-version-in-last-changelog 3 packages and 0 specfiles checked; 0 errors, 8 warnings. Especially, the version in the changelog entry and the capitalization, e.g.: Get metadata for Python modules Metaextract is a tool to collect ... Regarding the pytest-runner dependency - I changed it to `BuildRequires: %{py3_dist pytest}` and it builds fine in my Fedora 29 environment (where pytest-runner isn't installed: 'package python3-pytest-runner is not installed'), i.e. all the pytest tests are executed and succeed. (The tests just fail when I remove the `export PYTHONPATH...` line - probably because the unittests invoke via subprocess `python3 setup.py ...` which relies on that path.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
