https://bugzilla.redhat.com/show_bug.cgi?id=1658153 --- Comment #78 from Petr Menšík <pemensik@xxxxxxxxxx> --- Please do not use icon suffix in desktop files. It can find any supported type if used without it. wdune-0.99-3pl1482.fc29.x86_64//usr/share/applications/dune.desktop: error: (will be fatal in the future): value "dune.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path wdune-0.99-3pl1482.fc29.x86_64//usr/share/applications/dune4kids.desktop: error: (will be fatal in the future): value "dune4kids.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path Remove Recommends: freeglut-devel from main package. Instead, add Requires: freeglut to opengl-examples subpackage. It would make sense to add Requires: %{name}%{?_isa} = %{name}-%{version} to examples subpackage as well. Or it needs license file, but I think requires makes more sense. Also, examples are compiled without compiler flags provided by package system. They are not optimized. Compilation and linking should contain CXXFLAGS and LDFLAGS variable. g++ -g -o $@ might become: render_with_picture_path: ../libC++RWD.h C++Export.cc main.cpp $(CXX) -g $(CXXFLAGS) $(LDFLAGS) -o $@ -DPICTURE_PATH=\"/usr/share/white_dune\" -I. -I.. -Wno-narrowing main.cpp -lglut -lGLU -lGL -lXmu -lX11 -ljpeg -lpng It generates lots of warning, but it would add some safety checks into compiled binary. It is better to see those warnings than hide them, unless they are false positives. Another problem in examples, it has to own directory it adds files to or require package that owns it. In %files opengl-examples section, include whole %{_datadir}/white_dune. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
