[Bug 1695362] Review Request: python-metaextract - get metadata for python modules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1695362



--- Comment #4 from dan.cermak@xxxxxxxxxxxxxxxxxxx ---
(In reply to Georg Sauthoff from comment #2)
> You can simplify the %check section like this:
> 
> --- python-metaextract.spec.orig	2019-04-03 17:31:15.010362399 +0200
> +++ python-metaextract.spec	2019-04-03 17:51:39.050067347 +0200
> @@ -53,8 +53,7 @@
>  %py3_install
>  
>  %check
> -export PYTHONPATH=$(pwd):$PYTHONPATH
> -py.test-%{python3_version} -v metaextract
> +%{__python3} -m pytest -v metaextract
>  
>  %files -n python3-%{srcname}
>  %doc README.rst
> 
> 
> Also, do we really need
> 
> BuildRequires: %{py3_dist pytest-runner}
> 
> instead of
> 
> BuildRequires: %{py3_dist pytest}
> 
> ?

Unfortunately metaextract requires pytest-runner and not BuildRequiring it
causes the tests to fail.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux