Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: scim-python - a python wrapper for SCIM input platform https://bugzilla.redhat.com/show_bug.cgi?id=306431 ------- Additional Comments From panemade@xxxxxxxxx 2007-09-26 06:04 EST ------- * cool. So many comments. thanks to Jens and Mamoru. *rpmlint on SRPM says scim-python.src:54: W: macro-in-%changelog dir Macros are expanded in %changelog too, which can in unfortunate cases lead to the package not building at all, or other subtle unexpected conditions that affect the build. Even when that doesn't happen, the expansion results in possibly "rewriting history" on subsequent package revisions and generally odd entries eg. in source rpms, which is rarely wanted. Avoid use of macros in %changelog altogether, or use two '%'s to escape them, like '%%foo'. * on RPM it said scim-python.i386: W: symlink-should-be-relative /usr/lib/scim-1.0/IMEngine/scim-python.so /usr/lib/python2.5/site-packages/scim.so Absolute symlinks are problematic eg. when working with chroot environments. scim-python.i386: W: symlink-should-be-relative /usr/lib/scim-1.0/SetupUI/scim-python-setup.so /usr/lib/python2.5/site-packages/scim.so Absolute symlinks are problematic eg. when working with chroot environments. * And build.log showed warning: File listed twice: /usr/lib/python2.5/site-packages/scim.so So from %files section you should remove %{_libdir}/python*/site-packages/*.so * otherwise package looks ok. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review