https://bugzilla.redhat.com/show_bug.cgi?id=1691022 --- Comment #18 from Numan Siddique <numan.siddique@xxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #17) > > > > > > > > > > > - Use Fedora crypto default: > > > > > > > > ovn.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/ovn-nbctl > > > > SSL_CTX_set_cipher_list > > > > ovn.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/ovn-sbctl > > > > SSL_CTX_set_cipher_list > > > > ovn.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/ovn-trace > > > > SSL_CTX_set_cipher_list > > > > > > > > See https://docs.fedoraproject.org/en-US/packaging-guidelines/CryptoPolicies/ > > > > > > > > That is: patch lib/stream-ssl.c:1017 to use "PROFILE=SYSTEM" > > > > > > This requires changes int the openvswitch code and I will submit a patch to > > > the ovs-dev ML > > > to use "PROFILE=SYSTEM". I will update if that's acceptable or not. > > > > > Not sure upstream is interested in such a patch, this is a downstream > (Fedora) policy. Got it. Thanks. I will apply the patch to use "PRFOFILE=SYSTEM". > > (In reply to Numan Siddique from comment #15) > > > > OVN is part of OpenvSwitch and the source code is here - > > https://github.com/openvswitch/ovs/tree/master/ovn > > > > Compiling OpenvSwitch also compiles OVN. > > OVN doesn't make use of the above files listed by you. > > You think I still need to update the license ? > > > > Also the openvswitch spec file is here - > > https://src.fedoraproject.org/rpms/openvswitch/blob/master/f/openvswitch.spec > > and I took that as reference. > > > > We are only interested in the licenses of the shipping binaries, if they are > not included, then don't modify it. > Ack. > (In reply to Numan Siddique from comment #16) > > > > > > - Own these directories: > > > > > > [!]: Package requires other packages for directories it uses. > > > Note: No known owner of /usr/share/openvswitch, > > > /usr/lib/ocf/resource.d/ovn, /usr/share/openvswitch/scripts > > > > The directores - /usr/share/openvswitch and /usr/share/openvswitch/scripts > > are created > > by openvwitch package. I think the openvswitch.spec file should be modified > > to own these directories right ? > > > > Thanks > > Numan > > I've checked the openvswitch spec and indeed it doesn't own these > directories, which it should. > However, you still need either: > - own these directories with %dir, *or* > - Requires: openvswitch (assuming openvswitch is fixed) Right now I have aadded "Requires: openvswtich". I will talk to the openvswitch maintainer about it and ask him to fix it. Meanwhile I will change the ovn.spec to won these dirs. Thanks for the review comments. Numan > > Second solution is preferred in this case except if you don't wan't a hard > requires on openvswitch. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
