https://bugzilla.redhat.com/show_bug.cgi?id=1694735 Richard Shaw <hobbes1069@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #3 from Richard Shaw <hobbes1069@xxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #2) > - Could you write a more descriptive summary/description, for those who > have no idea what WSJT-X is, what does this program do? I updated the Summary which hopefully works better and copied some new text from the homepage for the full description. > - Use %set_build_flags instead > > export CFLAGS="%{optflags}" > export LDFLAGS="%{?__global_ldflags}" Those were left over from wsjtx (which this project forked from). I removed them and the build flags seemed to still be used. > - Consider writing an Appdata file for your app: > https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ I'll definitely work on that, but not a review blocker correct? > - Document why these patches are needed: a comment, a link to upstream bug > report or merge request: > > Patch0: js8call-sys_boost.patch > Patch1: js8call-hamlib.patch Done. > - Or you could just define a global commit with the hash: > > # Release 1.0.0 > %global commit 9423640e52a1 I originally created the repack shell script because upstream failed to exclude the .svn directory using the automatic archive download functionality of bitbucket which bloated the archive by 100%. They fixed that in later tags but I hadn't bothered to change my workflow. It's fixed now. > - Remove INSTALL file from docs: Done. > - Please see this issue with upstream: > > js8call.x86_64: W: executable-stack /usr/bin/js8 This is a side effect of the fortran code and I don't think anything can be done about it. I asked wsjtx upstream about it when it was being reviewed. https://sourceforge.net/p/wsjt/mailman/message/36195805/ --- SPEC: https://hobbes1069.fedorapeople.org/js8call.spec SRPM: https://hobbes1069.fedorapeople.org/js8call-1.0.0-2.fc29.src.rpm * Tue Apr 02 2019 Richard Shaw <hobbes1069@xxxxxxxxx> - 1.0.0-2 - Update spec per review request comments. Please set the fedora-review flag to "?" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
