https://bugzilla.redhat.com/show_bug.cgi?id=1691022 --- Comment #5 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - The obsoleted version should be the version the obsoleted package would have been if it was bumped Obsoletes: openvswitch-ovn-common < 2.11.0-3 and so on for all the Obsoletes. - Use %{?systemd_requires}: Requires(post): systemd-units Requires(preun): systemd-units Requires(postun): systemd-units - What's the purpose of this: %if 0%{?commit0:1} %setup -n ovs-%{commit0} -q -D -T %else %setup -n openvswitch-%{version} -q -D -T %endif you already ran %autosetup. That will only overwrite patches applied in %autosetup, which is probably not what you want. - What platform are you targeting that don't have systemd macros? They are even on EPEL7. Remove all the %if 0%{?systemd_*:1} conditionals. - Not useful: # Use Python3 %global _py python3 %global _py2 python2 You used %_py one time in the spec. - Have you discussed the obsoleting part with the current openvswitch maintainers? You need to coordinate together for this. I'll continue the review later. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
