https://bugzilla.redhat.com/show_bug.cgi?id=1694292 Artur Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx --- Comment #1 from Artur Iwicki <fedora@xxxxxxxxxx> --- >URL: www.yacreader.org I believe this should be prefixed with the schema (http:// or https://). https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ >BuildRequires: /usr/bin/desktop-file-validate You can use "desktop-file-utils" for this. >%{_datadir}/%{name}/server/docroot/css/reset.css >[...] >%{_datadir}/%{name}/server/templates/libraries_iphone.tpl Two things here: 1. While this list will make the package own files, the directories will remain unowned. You need to add "%dir %{_datadir}/%{name}". 2. Alternatively, you can replace the whole list with just "%{_datadir}/%{name}". This will include the directory and all its files (recursively). https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership >%{_mandir}/man1/%{appname}.1.gz >%{_mandir}/man1/%{appname}Library.1.gz Do not assume that man pages will be gzipped. While this is the case now, it might change sometime in the future. Use a wildcard so you can match any compression method. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
