[Bug 1691609] Review Request: python-yapf - A formatter for Python code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1691609



--- Comment #8 from Luis Bazan <bazanluis20@xxxxxxxxx> ---
SPEC: https://lbazan.fedorapeople.org/python-yapf.spec
SRPM: https://lbazan.fedorapeople.org/python-yapf-0.26.0-2.fc29.src.rpm

 - Please don't mix tabs and space in the SPEC. (FIXED)

 - The source is 404. It should be (with tabs removed): (FIXED)

$ rpmlint python-yapf.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

License:        ASL 2.0
URL:            https://github.com/google/yapf
Source0:        %{url}/archive/v%{version}/%{pypi_name}-%{version}.tar.gz(the
url FIXED)
BuildArch:      noarch

 - Consider keeping the timestamps:  (Added)

for lib in $(find . -type f -name "*.py"); do
 sed '1{\@^#!/usr/bin/env python@d}' $lib > $lib.new &&
 touch -r $lib $lib.new &&
 mv $lib.new $lib
done

 - Rename plugins/README.rst to README-plugins.rst otherwise both file are
written to the same place:

cp plugins/README.rst README-plugins.rst (FIXED)

%doc README-plugins.rst README.rst (FIXED)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux