https://bugzilla.redhat.com/show_bug.cgi?id=1693987 --- Comment #6 from jiri vanek <jvanek@xxxxxxxxxx> --- lease search *** for all nits highlights: - Package does not contain duplicates in %files. Note: BUILDSTDERR: warning: File listed twice: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/server/classes.jsa See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles *** Please check that and fix later - Bundled jar/class files should be removed before build Note: Jar files in source (see attachment) See: http://fedoraproject.org/wiki/Packaging:Java#Pre- built_JAR_files_.2F_Other_bundled_software' *** Those are IdealGraphVisualizer and tests. Please remove before build. *** I'm not sure what to do with /usr/share/icons/. Had global settings changed in since last review? /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64{-slowdebug}/lib should be fixed *** This is rename of java-openjdk package. Except reanimg, it does nothing else. This package can not obsolete java-openjdk, as it would obsolete java-1.8.0-openjdk via manual provides of java-openjdk it have. The java-openjdk package should be emptied together with this update, and should require this new package as its implementation(thoughts?). Thus this can be handled later out of this review. *** Suspicious is: java-latest-openjdk-devel!! [-]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in java-latest-openjdk, java-latest-openjdk-slowdebug *** partial bug in review, this is not necessary for f30 and up, but please dont forget it for f29+f28 java-latest-openjdk.src:2083: W: macro-in-%changelog %check *** shoudl be fixed atest-openjdk.src: W: invalid-url Source0: jdk-jdk12-jdk-12+33.tar.xz *** the usptream do not have osurce releases, they are generated by scripts which are in java-openjdk package *** Petra Alice, please dont forget to importa also those files (they are not in srpm[intentionally]) java-latest-openjdk-slowdebug.x86_64: W: undefined-non-weak-symbol /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64-slowdebug/lib/libawt_xawt.so JVM_GetMethodIxLocalsCount, java-latest-openjdk-slowdebug.x86_64: W: undefined-non-weak-symbol /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64-slowdebug/lib/libjawt.so JVM_IsSameClassPackage, java-latest-openjdk.x86_64: W: unused-direct-shlib-dependency /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libsplashscreen.so libjpeg.so.62 *** I dont know how this is ok/not ok. Lets discuss java-team here. java-latest-openjdk.x86_64: W: unstripped-binary-or-object /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libawt_xawt.so *** jdk is stripped in way, it can be actually useful -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
