https://bugzilla.redhat.com/show_bug.cgi?id=1655297 Xavier Bachelot <xavier@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xavier@xxxxxxxxxxxx --- Comment #4 from Xavier Bachelot <xavier@xxxxxxxxxxxx> --- > Version: 0.4.0 Latest version is 0.4.2.1. > Summary: A Qt5 library to write cross-platform clients for Matrix The leading 'A' is not needed. > Source0: https://github.com/QMatrixClient/%{name}/archive/v%{version}.tar.gz Use a better url to have a properly named tarball: https://github.com/QMatrixClient/%{name}/archive/v%{version}/%{name}-%{version}.tar.gz > %package devel > Requires: %{name}%{?isa} Requires: %{name}%{?_isa} = %{version}-%{release} > %build > mkdir -p build > pushd build > %{cmake} .. > %{__cmake} --build . --target all > popd ''' %build %cmake . %make_build ''' is enough. > %install > make install/fast DESTDIR=%{buildroot} -C build %make_install > %files > %{license} COPYING %license, no braces > %{_libdir}/libQMatrixClient.so.* Don't glob the soname to avoid un-noticed soname bump. > %files devel ...snip... > %{_includedir}/*.h > %{_includedir}/application-service/definitions/*.h > %{_includedir}/csapi/*.h > %{_includedir}/csapi/definitions/*h > %{_includedir}/csapi/definitions/wellknown/*h > %{_includedir}/events/*.h > %{_includedir}/identity/definitions/*.h > %{_includedir}/jobs/*.h %{_includedir}/* is enough But it is not correct to drop all files and dirs directly in %{_includedir}, it should be installed in a subdirectory. > %changelog > * Mon Dec 03 2018 Marc Deop marc@xxxxxxxxxxxx - 0.4.0-2 > - Do not use mkdir system macro > - Use arched dependency > * Sat Nov 24 2018 Marc Deop marc@xxxxxxxxxxxx - 0.4.0-1 > - Initial release The mail needs to be enclosed in < >. Add blank lines between changelog entries for legibility. Also : - Missing %ldconfig_scriptlets. That is really only necessary for el6 and el7, but expands to nothing on fedora, so it cannot hurt, shall one want EPEL branches. - CONTRIBUTING.md and possibly others could be shipped as %doc. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
