https://bugzilla.redhat.com/show_bug.cgi?id=1692593 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review+ --- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- + package name is OK + latest version + license is acceptable for Fedora (GPLv3) + license is specified correctly + builds and installs OK + BR look OK, Requires look OK too (I'm a bit suspicious if everything can be made optional...) rpmlint: > python3-visidata.noarch: E: script-without-shebang /usr/lib/python3.7/site-packages/visidata/man/vd.1 > visidata.noarch: W: spurious-executable-perm /usr/share/man/man1/vd.1.gz Just remove this file? This file is misplaced. I see the man page is already installed in the right place, so those two can be jsut removed. > python3-visidata.noarch: E: wrong-script-interpreter /usr/lib/python3.7/site-packages/visidata/colors.py /usr/bin/env python3 > python3-visidata.noarch: E: non-executable-script /usr/lib/python3.7/site-packages/visidata/colors.py 644 /usr/bin/env python3 > python3-visidata.noarch: E: wrong-script-interpreter /usr/lib/python3.7/site-packages/visidata/vdtui.py /usr/bin/env python3 > python3-visidata.noarch: E: non-executable-script /usr/lib/python3.7/site-packages/visidata/vdtui.py 644 /usr/bin/env python3 Not terribly important, but nice to fix. > python3-visidata.noarch: W: spelling-error %description -l en_US multitool -> multistory > visidata.noarch: W: spelling-error %description -l en_US multitool -> multistory > visidata.src: W: spelling-error %description -l en_US multitool -> multistory Bogus obviously. 3 packages and 0 specfiles checked; 5 errors, 4 warnings. All those seem very minor. Please fix when importing. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
