https://bugzilla.redhat.com/show_bug.cgi?id=1687217 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tibbs@xxxxxxxxxxx --- Comment #4 from Jason Tibbitts <tibbs@xxxxxxxxxxx> --- This is very interesting; ttyd looks like it could be a reasonable replacement for shellinabox (which has kind of gone unmaintained for a while). However it seems to me that the packaging is a bit barebones for something that I'd expect to provide a daemon. Shouldn't it at least provide a systemd unit, or was your intent not to do so? If the latter, how do you envision this package being used? I haven't gone through the entire build process but I'm curious about what happens to the bundled javascript bits. I guess it all ends up crammed into the pre-bompiled index.html and that gets compiled into the binary. But I'm not sure if that code is xterm.js, is derived from xterm.js or is something else; if it's bundled, that needs to be indicated here with Provides: bundled(xterm.js) = 3.2.0 or whatever the version is. And it appears to be pre-minimized, which causes its own issues about that needing to be built from source. Frankly I don't know much about webpack or how this even gets built, but I'm not sure that what's in the ttyd source tarball is all that's actually needed to completely rebuild everything from source. Another thing would be an selinux policy, but that's not at all required. I managed to get one working for shellinabox but it has a somewhat different scope. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
