[Bug 1691998] Review Request: golang-github-redis-v2 - Redis client for Go

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1691998

Nathan Scott <nathans@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request:             |Review Request:
                   |golang-gopkg-redis-2 -      |golang-github-redis-v2 -
                   |Redis client for Go         |Redis client for Go



--- Comment #13 from Nathan Scott <nathans@xxxxxxxxxx> ---
(In reply to Robert-André Mauchin from comment #10)
> Shouldn't -devel Requires: redis ?

It's a BuildRequires (for the tests) dependency only.  There's no need to have
a local Redis server when using this client library (i.e. the -devel install
has no runtime dependency).

>  - Seems they do not respect their own import path:

Just came across this too - it was an error in the paths from the 'ln' command
from #c8 - I've fixed it now.

> So I revert back my original idea, make gopkg.in/redis.v2 the main import
> path.

The 'source code' links on every redis-vN linked from e.g.
https://gopkg.in/redis.v2 point to tagged branches in the same
github.com/go-redis repository - so I disagree that "gopkg.in/redis.v2" should
be the main import.  IMO, the spec/srpm versions on fedorapeople now are fully
functional and fine as-is, and I think we're in danger of bike-shedding a bit
here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux