https://bugzilla.redhat.com/show_bug.cgi?id=1663668 --- Comment #7 from Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #5) > - %{buildroot}/usr/bin/k2hr3-osnl → %{buildroot}%{_bindir}/k2hr3-osnl > > - %attr(0755,root,root) and %attr(0644,root,root) shouldn't be needed. > > - You have this twice: %{_sysconfdir}/k2hr3 > > - I don't understand what you're doing here: > > %if 0%{?fedora} >= 30 > %{_unitdir}/k2hr3-osnl.service > %else > %{_unitdir}/k2hr3-osnl.service > %endif > > > Both branches of the condition contain the same thing? And there's nothing > specific to Fedora >= 30 regarding unit files. Hello Robert-André, Thank you very much for your comment. I have fixed the above. 1. SRPM https://hiwkby.fedorapeople.org/python-k2hr3-osnl-0.9.2-1.fc29.src.rpm 2. SPEC https://hiwkby.fedorapeople.org/python-k2hr3-osnl.spec 3. Successful Koji scratch build https://koji.fedoraproject.org/koji/taskinfo?taskID=33771656 Thanks in advance, Hirotaka Wakabayashi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
