https://bugzilla.redhat.com/show_bug.cgi?id=1691022 Numan Siddique <nusiddiq@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nusiddiq@xxxxxxxxxx --- Comment #3 from Numan Siddique <nusiddiq@xxxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #2) > Not a review, just a few comments > > - Not needed at the start of %install: > > rm -rf $RPM_BUILD_ROOT > > - Python 2 is deprecated in F30, you shouldn't build new packages with it: > > %if 0%{?fedora} > %global with_python2 1 > %else > %global with_python2 0 > %endif > > - Group: is not used in Fedora > > CC mrunge or amoralej? Thanks. I have addressed it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
