[Bug 1658153] Review Request: wdune - wdune (white_dune) is a graphical VRML97/X3D editor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1658153



--- Comment #73 from Petr Menšík <pemensik@xxxxxxxxxx> ---
(In reply to J. Scheurich from comment #57)
> (In reply to J. Scheurich from comment #56)
> > > Are you sure pititvi editor cannot be used? I never used that myself, but at
> > > least there is some editor available in Fedora. 
> 
> I get the following error if i try to use pititvi (flatpak installation)
> with a typical
> oldfashioned VRML movie file (mpeg 3):
> 
> Problem: gst-core-error-quark
> Extra information: gst-core-error-quark: Your GStreamer installation is
> missing a plug-in. (12)

Video codecs are not usually part of Fedora because of licensing problems. Have
you tried any video with free codec? I think anything downloaded by youtube-dl
would be open codec by default. Best guess is anything on AV1 family [1]. There
is nothing we can do about it. Gstreamer might have such codecs or not. Let it
handle it the best we can.

(In reply to J. Scheurich from comment #61)
> I fixed the 
> 
> PM build errors:
>     File must begin with "/": files
> 
> errors, but i am unable to fix the problem
> 
> error: Arch dependent binaries in noarch package
> 
> when i uncomment
> 
> #BuildArch: noarch

Problem is with file
docs/export_example_c++/opengl_example/render_with_picture_path. It is already
compiled binary and as such must NOT be packaged. noarch is correct for docs,
compiled program is not.

$ file docs/export_example_c++/opengl_example/render_with_picture_path
docs/export_example_c++/opengl_example/render_with_picture_path: ELF 64-bit LSB
shared object, x86-64, version 1 (SYSV), dynamically linked, interpreter
/lib64/ld-linux-x86-64.so.2, for GNU/Linux 3.2.0,
BuildID[sha1]=e456878b296073de1700877076e8ad33c9d9ca7e, with debug_info, not
stripped

Examples have to be compiled in %build phase. And compiled binaries must not be
part of %docs macro. Copy example out of docs subdirectory before building.
Install it into %{_bindir}, maybe %{_libexecdir}.
Why it Recommends: freeglut-devel for main package? I think it should be
freeglut. If example will not work without it, just make it Requires: freeglut
for subpackage opengl-examples only.

Please use empty line after each subpackage. They are too mixed together, hard
to read. Both for after files and descriptions.

Use pushd+popd:

%make_build

cp -a docs/export_example_c++/opengl_example opengl_example
pushd opengl_example
make render_with_picture_path
popd

1. https://en.wikipedia.org/wiki/AV1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux