https://bugzilla.redhat.com/show_bug.cgi?id=1692070 Chris Caron <lead2gold@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lead2gold@xxxxxxxxx --- Comment #1 from Chris Caron <lead2gold@xxxxxxxxx> --- Hi, I just reviewed your package and here is what I've found so far. Notes: - Changelog format needs to be updated slightly; see - https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs - python3-%{pypi_name} package entry is missing Requires: references. I presume you will require systemd and/or dbus to be availble? - you got a lot of /usr/bin/env python3 references in files that are clearly not meant to be executable. Removing these should clear up a good number of the rpmlint checks identified at the bottom - There are some minor spelling errors, but nothing major Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 30 files have unknown license. Detailed output of licensecheck in /home/l2g/Development/reviews/review-python- pystemd/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [-]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-pystemd [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-pystemd-0.6.0-1.fc29.x86_64.rpm python-pystemd-debugsource-0.6.0-1.fc29.x86_64.rpm python-pystemd-0.6.0-1.fc29.src.rpm python3-pystemd.x86_64: W: spelling-error Summary(en_US) libsystemd -> subsystem python3-pystemd.x86_64: W: spelling-error %description -l en_US systemd -> systems, system, system d python3-pystemd.x86_64: W: spelling-error %description -l en_US programmatically -> pro grammatically, pro-grammatically, programmatic ally python3-pystemd.x86_64: W: spelling-error %description -l en_US subprocessing -> sub processing, sub-processing, processioning python3-pystemd.x86_64: W: spelling-error %description -l en_US systemctl -> systemic python3-pystemd.x86_64: E: wrong-script-interpreter /usr/lib64/python3.7/site-packages/pystemd/DBus/__init__.py /usr/bin/env python3 python3-pystemd.x86_64: E: non-executable-script /usr/lib64/python3.7/site-packages/pystemd/DBus/__init__.py 644 /usr/bin/env python3 python3-pystemd.x86_64: E: wrong-script-interpreter /usr/lib64/python3.7/site-packages/pystemd/__init__.py /usr/bin/env python3 python3-pystemd.x86_64: E: non-executable-script /usr/lib64/python3.7/site-packages/pystemd/__init__.py 644 /usr/bin/env python3 python3-pystemd.x86_64: E: wrong-script-interpreter /usr/lib64/python3.7/site-packages/pystemd/__version__.py /usr/bin/env python3 python3-pystemd.x86_64: E: non-executable-script /usr/lib64/python3.7/site-packages/pystemd/__version__.py 644 /usr/bin/env python3 python3-pystemd.x86_64: E: wrong-script-interpreter /usr/lib64/python3.7/site-packages/pystemd/base.py /usr/bin/env python3 python3-pystemd.x86_64: E: non-executable-script /usr/lib64/python3.7/site-packages/pystemd/base.py 644 /usr/bin/env python3 python3-pystemd.x86_64: E: wrong-script-interpreter /usr/lib64/python3.7/site-packages/pystemd/exceptions.py /usr/bin/env python3 python3-pystemd.x86_64: E: non-executable-script /usr/lib64/python3.7/site-packages/pystemd/exceptions.py 644 /usr/bin/env python3 python3-pystemd.x86_64: E: wrong-script-interpreter /usr/lib64/python3.7/site-packages/pystemd/machine1/__init__.py /usr/bin/env python3 python3-pystemd.x86_64: E: non-executable-script /usr/lib64/python3.7/site-packages/pystemd/machine1/__init__.py 644 /usr/bin/env python3 python3-pystemd.x86_64: E: wrong-script-interpreter /usr/lib64/python3.7/site-packages/pystemd/machine1/machine.py /usr/bin/env python3 python3-pystemd.x86_64: E: non-executable-script /usr/lib64/python3.7/site-packages/pystemd/machine1/machine.py 644 /usr/bin/env python3 python3-pystemd.x86_64: E: wrong-script-interpreter /usr/lib64/python3.7/site-packages/pystemd/machine1/manager.py /usr/bin/env python3 python3-pystemd.x86_64: E: non-executable-script /usr/lib64/python3.7/site-packages/pystemd/machine1/manager.py 644 /usr/bin/env python3 python3-pystemd.x86_64: E: wrong-script-interpreter /usr/lib64/python3.7/site-packages/pystemd/run.py /usr/bin/env python3 python3-pystemd.x86_64: E: non-executable-script /usr/lib64/python3.7/site-packages/pystemd/run.py 644 /usr/bin/env python3 python3-pystemd.x86_64: E: wrong-script-interpreter /usr/lib64/python3.7/site-packages/pystemd/systemd1/__init__.py /usr/bin/env python3 python3-pystemd.x86_64: E: non-executable-script /usr/lib64/python3.7/site-packages/pystemd/systemd1/__init__.py 644 /usr/bin/env python3 python3-pystemd.x86_64: E: wrong-script-interpreter /usr/lib64/python3.7/site-packages/pystemd/systemd1/manager.py /usr/bin/env python3 python3-pystemd.x86_64: E: non-executable-script /usr/lib64/python3.7/site-packages/pystemd/systemd1/manager.py 644 /usr/bin/env python3 python3-pystemd.x86_64: E: wrong-script-interpreter /usr/lib64/python3.7/site-packages/pystemd/systemd1/unit.py /usr/bin/env python3 python3-pystemd.x86_64: E: non-executable-script /usr/lib64/python3.7/site-packages/pystemd/systemd1/unit.py 644 /usr/bin/env python3 python3-pystemd.x86_64: E: wrong-script-interpreter /usr/lib64/python3.7/site-packages/pystemd/systemd1/unit_signatures.py /usr/bin/env python3 python3-pystemd.x86_64: E: non-executable-script /usr/lib64/python3.7/site-packages/pystemd/systemd1/unit_signatures.py 644 /usr/bin/env python3 python3-pystemd.x86_64: E: wrong-script-interpreter /usr/lib64/python3.7/site-packages/pystemd/utils.py /usr/bin/env python3 python3-pystemd.x86_64: E: non-executable-script /usr/lib64/python3.7/site-packages/pystemd/utils.py 644 /usr/bin/env python3 python-pystemd.src: W: spelling-error Summary(en_US) libsystemd -> subsystem python-pystemd.src: W: spelling-error %description -l en_US systemd -> systems, system, system d python-pystemd.src: W: spelling-error %description -l en_US programmatically -> pro grammatically, pro-grammatically, programmatic ally python-pystemd.src: W: spelling-error %description -l en_US subprocessing -> sub processing, sub-processing, processioning python-pystemd.src: W: spelling-error %description -l en_US systemctl -> systemic 3 packages and 0 specfiles checked; 28 errors, 10 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory python3-pystemd.x86_64: W: spelling-error Summary(en_US) libsystemd -> subsystem python3-pystemd.x86_64: W: spelling-error %description -l en_US systemd -> systems, system, system d python3-pystemd.x86_64: W: spelling-error %description -l en_US programmatically -> pro grammatically, pro-grammatically, programmatic ally python3-pystemd.x86_64: W: spelling-error %description -l en_US subprocessing -> sub processing, sub-processing, processioning python3-pystemd.x86_64: W: spelling-error %description -l en_US systemctl -> systemic python3-pystemd.x86_64: E: wrong-script-interpreter /usr/lib64/python3.7/site-packages/pystemd/DBus/__init__.py /usr/bin/env python3 python3-pystemd.x86_64: E: non-executable-script /usr/lib64/python3.7/site-packages/pystemd/DBus/__init__.py 644 /usr/bin/env python3 python3-pystemd.x86_64: E: wrong-script-interpreter /usr/lib64/python3.7/site-packages/pystemd/__init__.py /usr/bin/env python3 python3-pystemd.x86_64: E: non-executable-script /usr/lib64/python3.7/site-packages/pystemd/__init__.py 644 /usr/bin/env python3 python3-pystemd.x86_64: E: wrong-script-interpreter /usr/lib64/python3.7/site-packages/pystemd/__version__.py /usr/bin/env python3 python3-pystemd.x86_64: E: non-executable-script /usr/lib64/python3.7/site-packages/pystemd/__version__.py 644 /usr/bin/env python3 python3-pystemd.x86_64: E: wrong-script-interpreter /usr/lib64/python3.7/site-packages/pystemd/base.py /usr/bin/env python3 python3-pystemd.x86_64: E: non-executable-script /usr/lib64/python3.7/site-packages/pystemd/base.py 644 /usr/bin/env python3 python3-pystemd.x86_64: E: wrong-script-interpreter /usr/lib64/python3.7/site-packages/pystemd/exceptions.py /usr/bin/env python3 python3-pystemd.x86_64: E: non-executable-script /usr/lib64/python3.7/site-packages/pystemd/exceptions.py 644 /usr/bin/env python3 python3-pystemd.x86_64: E: wrong-script-interpreter /usr/lib64/python3.7/site-packages/pystemd/machine1/__init__.py /usr/bin/env python3 python3-pystemd.x86_64: E: non-executable-script /usr/lib64/python3.7/site-packages/pystemd/machine1/__init__.py 644 /usr/bin/env python3 python3-pystemd.x86_64: E: wrong-script-interpreter /usr/lib64/python3.7/site-packages/pystemd/machine1/machine.py /usr/bin/env python3 python3-pystemd.x86_64: E: non-executable-script /usr/lib64/python3.7/site-packages/pystemd/machine1/machine.py 644 /usr/bin/env python3 python3-pystemd.x86_64: E: wrong-script-interpreter /usr/lib64/python3.7/site-packages/pystemd/machine1/manager.py /usr/bin/env python3 python3-pystemd.x86_64: E: non-executable-script /usr/lib64/python3.7/site-packages/pystemd/machine1/manager.py 644 /usr/bin/env python3 python3-pystemd.x86_64: E: wrong-script-interpreter /usr/lib64/python3.7/site-packages/pystemd/run.py /usr/bin/env python3 python3-pystemd.x86_64: E: non-executable-script /usr/lib64/python3.7/site-packages/pystemd/run.py 644 /usr/bin/env python3 python3-pystemd.x86_64: E: wrong-script-interpreter /usr/lib64/python3.7/site-packages/pystemd/systemd1/__init__.py /usr/bin/env python3 python3-pystemd.x86_64: E: non-executable-script /usr/lib64/python3.7/site-packages/pystemd/systemd1/__init__.py 644 /usr/bin/env python3 python3-pystemd.x86_64: E: wrong-script-interpreter /usr/lib64/python3.7/site-packages/pystemd/systemd1/manager.py /usr/bin/env python3 python3-pystemd.x86_64: E: non-executable-script /usr/lib64/python3.7/site-packages/pystemd/systemd1/manager.py 644 /usr/bin/env python3 python3-pystemd.x86_64: E: wrong-script-interpreter /usr/lib64/python3.7/site-packages/pystemd/systemd1/unit.py /usr/bin/env python3 python3-pystemd.x86_64: E: non-executable-script /usr/lib64/python3.7/site-packages/pystemd/systemd1/unit.py 644 /usr/bin/env python3 python3-pystemd.x86_64: E: wrong-script-interpreter /usr/lib64/python3.7/site-packages/pystemd/systemd1/unit_signatures.py /usr/bin/env python3 python3-pystemd.x86_64: E: non-executable-script /usr/lib64/python3.7/site-packages/pystemd/systemd1/unit_signatures.py 644 /usr/bin/env python3 python3-pystemd.x86_64: E: wrong-script-interpreter /usr/lib64/python3.7/site-packages/pystemd/utils.py /usr/bin/env python3 python3-pystemd.x86_64: E: non-executable-script /usr/lib64/python3.7/site-packages/pystemd/utils.py 644 /usr/bin/env python3 2 packages and 0 specfiles checked; 28 errors, 7 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
