https://bugzilla.redhat.com/show_bug.cgi?id=1671571 Dridi Boukelmoune <dridi.boukelmoune@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(dridi.boukelmoune | |@gmail.com) | --- Comment #29 from Dridi Boukelmoune <dridi.boukelmoune@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [!]: Package contains no static executables. You need an exception to ship the static library. Either get one or remove the static library in the first place. (Yes, I remember my previous comments on the topic=) [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License (v3 or later)". 21 files have unknown license. Detailed output of licensecheck in /home/dridi/fedora/FedoraReview/1671571-playerctl/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/include/playerctl, /usr/share/gtk- doc/html/playerctl [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gir-1.0, /usr/share/gtk-doc/html, /usr/lib64/girepository-1.0, /usr/include/playerctl, /usr/share/gtk-doc, /usr/share/gtk- doc/html/playerctl Use the following patterns instead: %{_includedir}/%{name}/ %{_datadir}/gtk-doc/ Add the following to the devel sub-package: equires: pkgconfig(gobject-introspection-1.0) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. The main package may conflict with itself on a multilib system and this is fine. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. The noarch docs package depends on the archful main package, which is debatable in the first place. At the very least, which variant of the main package should not be dictated by the build system's architecture. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). playerctl-devel.x86_64: W: no-documentation The devel sub-package could "Recommends:" the docs sub-package. On the other hand the documentation is quite small and could live in the devel package directly. The perl locale warnings needs more investigation. We either need to set the environment straight or bring the en-us langpack. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. It should however own a couple already mentioned above. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: playerctl-static. As noted above, an exception is needed to ship the static sub-package. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. Not quite true, but the docs sub-package (note: not "doc") is small enough to be folded [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [-]: Final provides and requires are sane (see attachments). See the note above regarding the noarch devel requiring an archful main package. [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in playerctl , playerctl-static , playerctl-debuginfo , playerctl- debugsource False-positives. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=33719966 [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. Handled by meson. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: playerctl-2.0.1-8.fc31.x86_64.rpm playerctl-devel-2.0.1-8.fc31.x86_64.rpm playerctl-docs-2.0.1-8.fc31.noarch.rpm playerctl-libs-2.0.1-8.fc31.x86_64.rpm playerctl-static-2.0.1-8.fc31.x86_64.rpm playerctl-debuginfo-2.0.1-8.fc31.x86_64.rpm playerctl-debugsource-2.0.1-8.fc31.x86_64.rpm playerctl-2.0.1-8.fc31.src.rpm playerctl.x86_64: W: spelling-error %description -l en_US statusline -> status line, status-line, stateliness playerctl.x86_64: W: spelling-error %description -l en_US introspectable -> introspect able, introspect-able, introspective playerctl.x86_64: W: spelling-error %description -l en_US spotify -> spottily playerctl.x86_64: W: spelling-error %description -l en_US vlc -> vac, VLF playerctl.x86_64: W: spelling-error %description -l en_US bmp -> mp, bump, imp playerctl.x86_64: W: spelling-error %description -l en_US cmus -> cums, mus, emus playerctl-devel.x86_64: W: no-documentation playerctl-libs.x86_64: W: no-documentation playerctl-static.x86_64: W: no-documentation playerctl.src: W: spelling-error %description -l en_US statusline -> status line, status-line, stateliness playerctl.src: W: spelling-error %description -l en_US introspectable -> introspect able, introspect-able, introspective playerctl.src: W: spelling-error %description -l en_US spotify -> spottily playerctl.src: W: spelling-error %description -l en_US vlc -> vac, VLF playerctl.src: W: spelling-error %description -l en_US bmp -> mp, bump, imp playerctl.src: W: spelling-error %description -l en_US cmus -> cums, mus, emus 8 packages and 0 specfiles checked; 0 errors, 15 warnings. Rpmlint (debuginfo) ------------------- Checking: playerctl-debuginfo-2.0.1-8.fc31.x86_64.rpm playerctl-libs-debuginfo-2.0.1-8.fc31.x86_64.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.utf8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.utf8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.utf8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). sh: /usr/bin/python: No such file or directory playerctl-docs.noarch: W: invalid-url URL: https://github.com/acrisci/playerctl <urlopen error [Errno -2] Name or service not known> playerctl.x86_64: W: spelling-error %description -l en_US statusline -> status line, status-line, stateliness playerctl.x86_64: W: spelling-error %description -l en_US introspectable -> introspect able, introspect-able, introspective playerctl.x86_64: W: spelling-error %description -l en_US spotify -> spottily playerctl.x86_64: W: spelling-error %description -l en_US vlc -> vac, VLF playerctl.x86_64: W: spelling-error %description -l en_US bmp -> mp, bump, imp playerctl.x86_64: W: spelling-error %description -l en_US cmus -> cums, mus, emus playerctl.x86_64: W: invalid-url URL: https://github.com/acrisci/playerctl <urlopen error [Errno -2] Name or service not known> playerctl-libs.x86_64: W: invalid-url URL: https://github.com/acrisci/playerctl <urlopen error [Errno -2] Name or service not known> playerctl-libs.x86_64: W: no-documentation playerctl-libs-debuginfo.x86_64: W: invalid-url URL: https://github.com/acrisci/playerctl <urlopen error [Errno -2] Name or service not known> playerctl-devel.x86_64: W: invalid-url URL: https://github.com/acrisci/playerctl <urlopen error [Errno -2] Name or service not known> playerctl-devel.x86_64: W: no-documentation playerctl-debugsource.x86_64: W: invalid-url URL: https://github.com/acrisci/playerctl <urlopen error [Errno -2] Name or service not known> playerctl-static.x86_64: W: invalid-url URL: https://github.com/acrisci/playerctl <urlopen error [Errno -2] Name or service not known> playerctl-static.x86_64: W: no-documentation playerctl-debuginfo.x86_64: W: invalid-url URL: https://github.com/acrisci/playerctl <urlopen error [Errno -2] Name or service not known> 8 packages and 0 specfiles checked; 0 errors, 17 warnings. Source checksums ---------------- https://github.com/acrisci/playerctl/releases/download/v2.0.1/playerctl-2.0.1.tar.xz : CHECKSUM(SHA256) this package : c3ae6d74ddd951767da4e7852a76a88a2920ed02f126dab6e3b6f0c77549c74f CHECKSUM(SHA256) upstream package : c3ae6d74ddd951767da4e7852a76a88a2920ed02f126dab6e3b6f0c77549c74f Requires -------- playerctl (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libplayerctl.so.2()(64bit) playerctl-libs(x86-64) rtld(GNU_HASH) playerctl-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libplayerctl.so.2()(64bit) pkgconfig(gio-2.0) pkgconfig(gio-unix-2.0) pkgconfig(gobject-2.0) playerctl(x86-64) playerctl-docs (rpmlib, GLIBC filtered): playerctl(x86-64) playerctl-libs (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) playerctl(x86-64) rtld(GNU_HASH) playerctl-static (rpmlib, GLIBC filtered): playerctl-devel(x86-64) playerctl-debuginfo (rpmlib, GLIBC filtered): playerctl-debugsource (rpmlib, GLIBC filtered): Provides -------- playerctl: playerctl playerctl(x86-64) playerctl-devel: pkgconfig(playerctl) playerctl-devel playerctl-devel(x86-64) playerctl-docs: playerctl-docs playerctl-libs: libplayerctl.so.2()(64bit) playerctl-libs playerctl-libs(x86-64) playerctl-static: playerctl-static playerctl-static(x86-64) playerctl-debuginfo: debuginfo(build-id) playerctl-debuginfo playerctl-debuginfo(x86-64) playerctl-debugsource: playerctl-debugsource playerctl-debugsource(x86-64) Generated by fedora-review 0.6.1 (37b2325) last change: 2019-03-10 Command line :try-fedora-review -b 1671571 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: fonts, Java, SugarActivity, R, PHP, Perl, Haskell, Python, Ruby, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
