[Bug 1690482] Review Request: group-service - Dbus Group management tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1690482



--- Comment #4 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
(In reply to Wolfgang Ulbrich from comment #2)
> > In order to avoid unintentional soname bumped, we now forbid globbing the major soname version:
> 
> Who is we ?
> I am fedora too ;)
> A link to docs would be helpful....
> 
FPC: https://pagure.io/packaging-committee/issue/784
ML:
https://lists.fedoraproject.org/archives/list/devel-announce@xxxxxxxxxxxxxxxxxxxxxxx/thread/OTYRDBXF4DJDTDAWIREKNLJI56XJMD73/
Docs:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files

> Btw. see upstream comment about.
> https://github.com/zhuyaliang/group-service/issues/2#issuecomment-474172760
> It well be fixed to use /usr/include/group-service-1.0/

(In reply to Wolfgang Ulbrich from comment #3)
> And fixed with
> https://github.com/zhuyaliang/group-service/commit/
> 735619ab5f9e74e2c9f5d86060dfa3cfe8054d00
> 
> 
> Download link are wrong from github, the copied link from release side is
> https://github.com/zhuyaliang/group-service/archive/1.1.0.tar.gz
> For this reason i use 
> 
> Source0:       %url/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz

No, Github automatically renames the file  with:
%url/archive/%{version}/%{name}-%{version}.tar.gz
The hack with "#/" is not necessary.(In reply to Wolfgang Ulbrich from comment
#2)

> 
> Btw. see upstream comment about.
> https://github.com/zhuyaliang/group-service/issues/2#issuecomment-474172760
> It well be fixed to use /usr/include/group-service-1.0/

Ok but your current SPEC has group-service-1.1, so you should change to
group-service-1.0.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux