https://bugzilla.redhat.com/show_bug.cgi?id=1691165 --- Comment #3 from Dan Radez <dradez@xxxxxxxxxx> --- Thanks for the review Matthias! - %{_datadir}/ansible/ does not exist, it gets created, but is owned by nothing - same for %{_datadir}/ansible/roles/ and %{_datadir}/ansible/roles/%{ansible_runner} - you only own the files inside %{_datadir}/ansible/roles/%{ansible_runner}, but not the dir itself I think you meant %{ansible_role} not %{ansible_runner}? I shouldn't have any ansible runner references in here except the Requires lines. I've moved this collection of files to /etc/ansible/roles which is provided by the ansible package. I get lots of warnings here that non-conf files are being put in /etc Should I label them conf files to get rid of these warnings? the Anisble package doesn't provide another place to put these. -------- - no test is executed. Then you could probably remove the %check section (it does nothing) I commented it and indicated there are not any upstream tests to execute yet. -------- - cross sub-package dependency: does the ansible role subpacakge depend in any case on python-network-runner? If yes, please add a dependency No dep needed. I've added a comment to indicate this -------- - for fedora-30, python2 has been removed. There is no /usr/bin/python anymore. removed the py2 references New spec and srpm have been uploaded. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
