https://bugzilla.redhat.com/show_bug.cgi?id=1686506 --- Comment #24 from Lubomir Rintel <lkundrak@xxxxx> --- (In reply to Jason A. Donenfeld from comment #23) > > I have the ability to sponsor him myself if he'd like when the package is finalized. > > Is there any reason for this order of operations? Not really. Other than there's not much he can do until the package is actually imported. > (In reply to Joe Doss from comment #20) > > (In reply to Robert-André Mauchin from comment #18) ... > > Maybe it is just better to wait until WireGuard goes into the mainline > > kernel and Fedora picks it up so we don't need to make any choices here? > > > > That's what I intended to do initially. But it seems Lubomir wants it in > early? > It would be easier otherwise. Sorry if I made that impression. I merely wanted the bits in, totally oblivious to anyone's third party packages or possible problems with them. I'm not in a hurry. I'm glad that you two got in touch regarding eventually adding this to Fedora. I'm totally fine if the bits are imported to Fedora only after WireGuard is mainlined. If anything, we'll have plenty of time to iron out the wrinkles by then. That said, I will not delay my approval when the package passes review -- I fully count on you to import the package at appropriate time. Also, I suppose Joe's packager status can be sorted by then as well. --- My $0.02 about the RPM Fusion and COPR migrations: we should not bend backwards to make up for things broken outside Fedora. The COPR users are warned that COPR packages are unofficial and "quality may vary". When things break, which is what tends to happen when packages escape quality control or coordination, the users should be expected to keep both parts. That said, I'm not going to object bits that would be there to ease the upgrade pain, if they're not totally unreasonable. An Epoch:, or Provides:/Obsoletes: would be fine. Now back to the usual review business. (In reply to Robert-André Mauchin from comment #22) > Spec URL: https://eclipseo.fedorapeople.org/wireguard-tools.spec > SRPM URL: > https://eclipseo.fedorapeople.org/wireguard-tools-0.0.20190227-2.fc31.src.rpm 1.) Please don't add this package: > %package -n wireguard > Summary: Metapackage providing the WireGuard tools and the WireGuard kernel module It does not make any sense in Fedora context. If you intend to cope with the kmod mess either add the metapackage to the same repository where the kmod lives or just bring back the weak dependency. Other than that the package looks good to me. Thank you! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
