[Bug 1690046] Review Request: Charliecloud - unprivileged container runtime

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1690046



--- Comment #2 from Dave Love <dave.love@xxxxxxxxxxxxxxxx> ---
I didn't realize this would need sponsorship as well as review.

Anyway, it needs work.  The first requirement is to build, which it doesn't on
rawhide, at least.  You should do scratch builds, taking into account
the differences between el7 and rawhide.  There are various other
things that need fixing which I haven't got time for immediately, but
have a look at
https://copr-dist-git.fedorainfracloud.org/cgit/loveshack/charliecloud/charliecloud.git/tree/
in comparison.  I'm not sure of the merits of shipping the test files,
but they should be in a separate package -- they're not documentation
-- and all you need to avoid the issue of compiling with the wrong
python cleanly is to define the right one, and you need versioned
python now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux