https://bugzilla.redhat.com/show_bug.cgi?id=1689397 --- Comment #2 from Gabriel Somlo <somlo@xxxxxxx> --- Thanks for the review! (In reply to Robert-André Mauchin from comment #1) > - %{__rm}, %{__mv}, %{__sed}, %{__mkdir}, %{__install} → rm, mv, sed, > mkdir, install -p > > (Note the -p here to keep timestamps) Done. > > - Why do you package a dev snapshot while the release is so recent? The database submodule doesn't have a release tag (yet), so I'd have to grab a snapshot of it regardless. Besides, a few useful commits were applied right after the release tag was added along the way. The package, while stable, is still gaining new and very useful features quite frequently, so I plan on tracking dev snapshots for a while yet before things slow down. > - Not sure what system you're during but all Python packages now must start > with either python2 of python3: > > Last metadata expiration check: 0:00:42 ago on Mon Mar 18 20:18:35 2019. > No matching package to install: 'python-recommonmark' > > # for building docs: > BuildRequires: python3-sphinx-latex > BuildRequires: python3-recommonmark OK on python3-recommonmark. However, python3-sphinx-latex only exists in rawhide. All the way up to (and including) F30, it's simply "python-sphinx-latex". At least on F28, "BuildRequires python3-sphinx-latex" returns an "package not found" error during mock build. > - [!]: Large data in /usr/share should live in a noarch subpackage if > package > is arched. > Note: Arch-ed rpms have a total of 59760640 bytes in /usr/share > trellis-1.0-0.1.20190315git26d6667.fc31.x86_64.rpm:59648000 > See: > > https://fedoraproject.org/wiki/Packaging: > ReviewGuidelines#Package_Review_Guidelines > > Could you make anoarch -data subpackage for %{_datadir}/%{name}? Done. See updated spec file at http://www.contrib.andrew.cmu.edu/~somlo/trellis-rpm/trellis.spec and the new SRPM at http://www.contrib.andrew.cmu.edu/~somlo/trellis-rpm/trellis-1.0-0.1.20190319git26d6667.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
