[Bug 1545479] Review Request: hcc- Heterogeneous C++ Compiler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1545479



--- Comment #14 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
%if 0%{?__isa_bits} == 64
%global build_libdir lib64/
%else
%global build_libdir lib/
%endif

 - Why not use %{_lib}? It resolves to either lib or lib64 depending on the
arch.

 -
        -DCMAKE_INSTALL_PREFIX=%{buildroot}/usr \

→

        -DCMAKE_INSTALL_PREFIX=%{buildroot}%{_prefix} \

 - %{_includedir}/* in %files

Includes should go to a devel package

%{_libdir}/cmake/hcc/ too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux