https://bugzilla.redhat.com/show_bug.cgi?id=1658153 --- Comment #52 from Petr Menšík <pemensik@xxxxxxxxxx> --- Thank you for pkg-config usage. It uses less flags but they are more accurate. 1) Since doc subpackage does not contain license, it must depend on the same version of main package. No package can be installed without license. 2) If you wanted to use extraver in %setup, use something like %setup -q -n "wdune-%{upstream_version}" 3) (In reply to J. Scheurich from comment #47) > (In reply to Petr Menšík from comment #44) > > It looks like rezound, wavesurfer, gnusound and soundeditor are not part of > fedora 30 > > # dnf install rezound wavesurfer gnusound sweep soundeditor > Last metadata expiration check: 0:00:32 ago on Sat 09 Mar 2019 01:25:39 AM > CET. > No match for argument: rezound > No match for argument: wavesurfer > No match for argument: gnusound > No match for argument: soundeditor > Error: Unable to find a match > # Ok, did not check them. If we have only one similar editor in Fedora, there is no point making wrappers around it. Recommends would work just fine. But I proposed that as generic pattern. I am sure Fedora has more terminals and more bitmap editors available. It could reuse similar approach. But that would be just nice to have feature. 4) If there is no change in docs dependent on architecture, they should be marked as noarch. %package docs BuildArch: noarch ... It might be nice to have already compiled examples from code provided however. For example in examples subpackage. If they are small and do not have additional dependencies, they might be part of wdune itself. Just with some prefix, like wdune-opengl-example. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
