https://bugzilla.redhat.com/show_bug.cgi?id=1677989 --- Comment #17 from Petr Menšík <pemensik@xxxxxxxxxx> --- No! No prefix of such kind is necessary here, on the contrary. If you check what flags are supplied by pkg-config vcglib, which we have now installed: $ pkg-config --cflags vcglib -I/usr/include/vcglib -I/usr/include/eigen3 It configures flags of compiler to look into vcglib and eigen3 subdirectories in /usr/include. That means you can just use #include <Eigen/Eigen>, and it would find header file located in /usr/include/eigen3/Eigen/Eigen. I think that is how authors of Eigen library want it to be used [1]. Similar way with #include <vcg/complex/complex.h>. Just tell it where to look for headers if they are not directly under /usr/include. If someone wanted to still use bundled eigenlib, he has to only add -Ieigenlib to compiler flags, no other change of source files would be required. I am sure we do not want to prefix includes in header files with unnecessary modifications, especially if they are not required with pkg-config usage. I think CPPFLAGS="-I/usr/include/eigen3" are user-friendly enough even without pkg-config. Please modify headers in %prep, maybe in %build. %install should only install already produced files from previous phases into target directories of the system. "fedpkg --release master prep" or "fedpkg --release master compile" commands should prepare ready-to-use local compilation of package, that can be used in source directory. It is possible to use such directory for --with-vcglib=... from wdune this way. It is handy for testing any modifications before you have to install produced package. 1. https://eigen.tuxfamily.org/dox-devel/GettingStarted.html -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
