https://bugzilla.redhat.com/show_bug.cgi?id=1187030 --- Comment #20 from Joachim Frieben <jfrieben@xxxxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #19) Hi Robert-André, first of all thanks a lot for reviewing the latest build! Regarding your comments, let me reply as follows: 1. Macros like "%{__rm} → rm" are official definitions provided by /usr/lib/rpm/macros which is part of redhat-rpm-config. I do agree that using such macros may be not very useful. However, this is a matter of taste, and I would actually rather keep them. 2. Globbing the major version has indeed been recently deprecated by Fedora. Your point is therefore absolutely valid, and I have changed %{_libdir}/*.so.* to %{_libdir}/*.so.0* as you have suggested. 3. Even though dropping ldconfig is rather a recommendation than a requirement, I have removed %post and %postun sections according to your suggestion. 4. Adding gcc as a BR is superfluous since gcc-gfortran is already a build requirement and already requires gcc itself. 5. I have silenced setup adopting "%setup -qn %{name}-%{version}" as you have suggested. 6. The build option "%global _smp_mflags -j1" is necessary because one Fortran source file depends on the presence of a Fortran module provided by some other Fortran source file. This dependency requires serial compilation. In the past, the corresponding race condition occasionally led to abortion of the build process when the necessary Fortran module could not be found by the compiler. Interestingly, during the few trials I have made with a parallel build of the current package, no problem was observed. Nevertheless, the root cause has not changed. I therefore prefer to disable parallel build for this package which only has a small size anyway. 7. I have added the content of docs/ to the newly created doc directory of giza-devel according to your request. An updated build giza-1.1.0-2.fc31 is available at: https://copr-be.cloud.fedoraproject.org/results/frieben/giza/fedora-rawhide-x86_64/00869543-giza/giza.spec https://copr-be.cloud.fedoraproject.org/results/frieben/giza/fedora-rawhide-x86_64/00869543-giza/giza-1.1.0-2.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
