Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: alsa-utils https://bugzilla.redhat.com/show_bug.cgi?id=225242 ------- Additional Comments From matthias@xxxxxxxxxxxx 2007-09-25 05:01 EST ------- (In reply to comment #5) > (In reply to comment #4) > > Additional cleanups : > > - Pick either tabs or spaces for identing, but not both. > > - Why is the -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 still needed? The > > configure script only has a "--disable-largefile" option, so I'd assume it's > > enabled by default. If it's still needed, a quick comment would be a good thing. > > Aha. Unfortunately I have 64bit system so it's that always enabled there. I'll > try to check it on some i386. I've compared builds for i386 and for x86_64, and configure displays this for both : checking for special C compiler options needed for large files... no checking for _FILE_OFFSET_BITS value needed for large files... no checking for _LARGE_FILES value needed for large files... no It's very likely that the override was needed at some point, but not any more it seems. > > - The "/var/lib/alsa" line would be clearer as "%dir /var/lib/alsa/" since > > nothing below it is included (only asound.state, but it's %ghost'ed). > > Feel free to fix it. OK, I've done that, as well as changed the indentation to be the same as alsa-lib.spec. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review