https://bugzilla.redhat.com/show_bug.cgi?id=1674278 --- Comment #24 from idf31@xxxxxxxxxxxxxx --- Sorry for my absence, I've been busy with school. (In reply to Michael Schwendt from comment #23) > If no license file is included in the source package, there is no > requirement for the packager to add one: > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > LicensingGuidelines/#_license_text > > > > %{_mandir}/man1/tty-clock.1.* > > The only reason to use '*' as to match more than the single installed manual > page is to be prepared for the automatic compression of manual pages to get > changed or disabled. Currently, it's ".gz", but that may change also due to > local customizations. With compression turned off, the package build would > fail. Hence it would be more safer to write: > > %{_mandir}/man1/tty-clock.1* (In reply to Robert-André Mauchin from comment #22) > - You must install the LICENSE file with %license in %files > > %license LICENSE > > - Use %set_build_flags to set Fedora build flags: > > %build > %set_build_flags > %make_build > > - Separate your changelog entries by a new line for readability I've modified >%{_mandir}/man1/tty-clock.1.* to >%{_mandir}/man1/tty-clock.1* and added >%set_build_flags Regarding the LICENSE file, the upstream doesn't have a license file in it's release source. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
