Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Package Review: taipeifonts (split from fonts-chinese). https://bugzilla.redhat.com/show_bug.cgi?id=253812 ------- Additional Comments From petersen@xxxxxxxxxx 2007-09-25 03:16 EST ------- Review follows: Good: + rpmlint clean + name follows upstream name (from CLE project) + meets packaging guidelines + fonts are public domain (no license file is included) + spec file is clear + dir and file ownership is good + macros used Needs attention: - no source url - noarch package builds - buildreqs listed Dunno if it is not a good idea to include say http://ftp2.tnc.edu.tw/pub3/CLE/CLE/devel/wjwu/slackware/slackware-9.1/source/taipeifonts-1.2/re-build.readme -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review