https://bugzilla.redhat.com/show_bug.cgi?id=1689277 --- Comment #7 from Richard W.M. Jones <rjones@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc gcc-c++ make See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. Licensing seems clear (GPLv3+). However source files in the project do not contain properly formatted GPL notices. While this is not an absolute requirement, it would greatly help and I think you should make that change upstream. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/make-it-quick, /usr/share/make-it- quick/config, /usr/include/make-it-quick Package needs to own these directories. You could either add: %dir %{_datarootdir}/%{name} (for each %dir) or you could simply specify the directory and rpmbuild will recursively find every file in the directory, eg: %{_datarootdir}/%{name} In the second case you risk adding files unintentionally to the final package. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/make-it-quick, /usr/share/make-it-quick/config, /usr/include/make-it-quick See previous point. [x]: Package contains no bundled libraries without FPC exception. [-]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [!]: Development files must be in a -devel package I think the pkg-config file (*.pc) should probably go into a -devel subpackage. It's at least arguable since the whole package is for development, but it seems like it may be better. I'm assuming the *.c files are used for normal operation and so should stay in the main package, even though rpmlint warns. [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [?]: Package obeys FHS, except libexecdir and /usr/target. Use of /usr/include is dubious. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [?]: Requires correct, justified where necessary. Does it require 'make' at runtime? It doesn't depend on it at runtime. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. Did not test. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 3 files. [ ]: Package complies to the Packaging Guidelines See concerns above. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). Maybe missing 'make' dependency at runtime. [ ]: Package functions as described. Did not test. Should it have a %check section which tests the package performs minimally? [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [?]: The placement of pkgconfig(.pc) files are correct. Note: make-it-quick : /usr/share/pkgconfig/make-it-quick.pc [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Rpmlint ------- Checking: make-it-quick-0.2.2-1.fc29.noarch.rpm make-it-quick-0.2.2-1.fc29.src.rpm make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_alloca.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_clearenv.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_drand48.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_egl.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_gdk_event_get_scancode.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_getpeereid.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_glob.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_gstaudio.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_gstvideo.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_int64.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_longlong.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_mingw_aligned_malloc.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_polkit_authority_get_sync.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_polkit_authorization_result_get_dismissed.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_posix_memalign.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_pulse.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_sasl.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_sbrk.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_sigaction.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_strtok_r.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_struct_sigaction.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_struct_stat.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_uchar.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_uint.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_ulong.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_ushort.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/pkgconfig/make-it-quick.pc 2 packages and 0 specfiles checked; 0 errors, 27 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory make-it-quick.noarch: W: invalid-url URL: https://gitlab.com/c3d/make-it-quick <urlopen error [Errno -2] Name or service not known> make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_alloca.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_clearenv.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_drand48.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_egl.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_gdk_event_get_scancode.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_getpeereid.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_glob.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_gstaudio.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_gstvideo.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_int64.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_longlong.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_mingw_aligned_malloc.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_polkit_authority_get_sync.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_polkit_authorization_result_get_dismissed.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_posix_memalign.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_pulse.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_sasl.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_sbrk.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_sigaction.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_strtok_r.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_struct_sigaction.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_struct_stat.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_uchar.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_uint.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_ulong.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_ushort.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/pkgconfig/make-it-quick.pc 1 packages and 0 specfiles checked; 0 errors, 28 warnings. Requires -------- make-it-quick (rpmlib, GLIBC filtered): /usr/bin/pkg-config sed Provides -------- make-it-quick: make-it-quick pkgconfig(make-it-quick) Source checksums ---------------- https://github.com/c3d/make-it-quick/archive/v0.2.2/make-it-quick-0.2.2.tar.gz : CHECKSUM(SHA256) this package : 7fad45b253e1a65da93ddedc023f64017373a0fe9102a3a96516531d788f648f CHECKSUM(SHA256) upstream package : 7fad45b253e1a65da93ddedc023f64017373a0fe9102a3a96516531d788f648f Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1689277 Buildroot used: fedora-29-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
