https://bugzilla.redhat.com/show_bug.cgi?id=1689277 --- Comment #5 from Christophe de Dinechin <dinechin@xxxxxxxxxx> --- (In reply to Richard W.M. Jones from comment #4) > Comments on the spec file while fedora-review is running: > > Spec file looks sane and is quite simple. > > I guess COLORIZE stops the build system emitting ANSI color codes? If it's > doing that, instead it should be checking isatty and suppressing them > automatically. Good idea, will check if [ -t 1 ] works portably (I'm concerned about mingw) > > /usr/include looks like an odd place to be putting *.mk files. As they > appear to be Makefile fragments intended for use by the tool it seems > as if %{_datadir}/%{name} or %{_libdir}/%{name} might be better choices (the > former if they are strictly arch-independent, the latter if not). > Considering that you're already using %{_datadir}/%{name} too ... Actually, this allows makefiles to do "include "make-it-quick/rules.mk" and everything works. As far as I know, make only looks under /usr/include. > > I'm not sure what the difference is between %{_datadir} and %{_datarootdir}. > I have only ever used %{_datadir}. However they both expand to the > same thing on my local machine. I don't know either, I copied that from another spec file (SPICE I believe) > > rpmlint is complaining a lot about > > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_alloca.c > > However given the nature of the package I think we can pass on that warning. Yes, I mentioned it in comment #1. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
