https://bugzilla.redhat.com/show_bug.cgi?id=1677989 --- Comment #15 from Petr Menšík <pemensik@xxxxxxxxxx> --- 1) Requires: %{name} is not enough. It has to be versioned, must depend on same. And depend also on the same architecture. Like I mentioned in comment #13. 2) eigenlib prefix from includes has to be removed in installed headers. Place something like this into %prep: And add BuildRequires: sed find vcg img wrap -name '*.h' -exec sed -i '{}' \ -e '/^#include/ s/<eigenlib\//</' \ -e '/^#include/ s,"../../eigenlib/\(.*\)",<\1>,' \ ';' 3) Ok, unfortunately wrap subdirectory is required, cannot be omitted. Contains headers used by other vcg headers. What is worse, wrap contains code in cpp files that should be compiled into shared library. But no single project file is prepared for real library. I think until full featured package is prepared, we can copy just that part of wrap, that does not require compilation. Wdune seems to link with it just with fine. I think these parts are required: mkdir -p %{buildroot}%{_includedir}/%{name}/wrap cp -a wrap/*.h wrap/{gcache,gl,glw,igl,io_edgemesh,io_tetramesh,io_trimesh,math,minpack,mt,opensg,system} %{buildroot}%{_includedir}/%{name}/wrap Mention why that was required in a comment -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
