https://bugzilla.redhat.com/show_bug.cgi?id=1688873 --- Comment #4 from Timothée Floure <timothee.floure@xxxxxxx> --- (In reply to Jan Staněk from comment #2) > Well, beside adding an explicit conflict with sway < 1.0 ;) Implicit > conflicts should not be allowed – see [1]. Oops, I feel a bit dumb missing this one. > On which fedoras is the sway update planned? I should probably only request > stable branches for those where the swaylock and sway can be actually > installed next to each other. I don't think it has been decided yet. Fedora 30 would be nice but the schedule might be a bit tight? Can we provide sway 1.0 as a module to provide some kind of "backports" if we miss F30? That's something to discuss with the other packagers in 1672268 [0]. > Also, while running a scratch review for myself, I run into issue with > ownership of the directories for the completion scripts -- they should also > be owned by the package ([2]). Be aware that this will generate shared > directory ownership warning in `fedora-review`, but that one always has > false positives :) I suggest deleting the listing of packages that also > share the directories and verifying that the list looks sane. I got some warnings for this (and checked a few other packages shipping completion files for shells) but missed the ownership rule for the parent directory. < %{_sysconfdir}/pam.d/%{name} --- > %config(noreplace) %{_sysconfdir}/pam.d/%{name} Fixes non-conffile-in-etc warning following the guidelines in [1]. Looks good to me. Thanks for the detailed comment, I learned a few things! I'm re-running fedora-review and will re-flag this bug once I've taken another look at the result. [0] https://bugzilla.redhat.com/show_bug.cgi?id=1672268 [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_configuration_files -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
