[Bug 1671571] Review Request: playerctl - MPRIS command-line controller and library for spotify, vlc, audacious, bmp, cmus, and others

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1671571



--- Comment #27 from Neal Gompa <ngompa13@xxxxxxxxx> ---
> %package devel
> Summary:        Development libraries and header files for %{name}
> Requires:       %{name}%{?_isa} = %{version}-%{release}
> 
> 
> %package docs
> Summary:        Documentation related to %{name}
> BuildArch:      noarch
> Requires:       %{name}%{?_isa} = %{version}-%{release}
> 
> 
> %package libs
> Summary:        Libraries and shared code for %{name}
> Requires:       %{name}%{?_isa} = %{version}-%{release}
> 
> 
> %package static
> Summary:        Static libraries for %{name} development
> Requires:       %{name}-devel%{?_isa} = %{version}-%{release}
> 
> 
> %description devel
> %{summary}.
> 
> 
> %description docs
> %{summary}.
> 
> 
> %description libs
> %{summary}.
> 
> 
> %description static
> %{summary}.

This layout is actually broken. It's not obvious, but the %summary variable is
populated by the _last_ definition of the 'Summary:' field at the time the
%description section was evaluated.

So, this leads to quirks like this:
> $ rpm -qip /var/lib/mock/fedora-29-x86_64/result/playerctl-devel-2.0.1-7.fc29.x86_64.rpm
> Name        : playerctl-devel
> Version     : 2.0.1
> Release     : 7.fc29
> Architecture: x86_64
> Install Date: (not installed)
> Group       : Unspecified
> Size        : 68295
> License     : LGPLv3+
> Signature   : (none)
> Source RPM  : playerctl-2.0.1-7.fc29.src.rpm
> Build Date  : Fri 15 Mar 2019 08:24:37 AM EDT
> Build Host  : localhost
> Relocations : (not relocatable)
> URL         : https://github.com/acrisci/playerctl
> Summary     : Development libraries and header files for playerctl
> Description :
> Static libraries for playerctl development.

Make sure the %description section is directly underneath each %package
section, unless you want to write the descriptions individually.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux