https://bugzilla.redhat.com/show_bug.cgi?id=1688873 Jan Staněk <jstanek@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review+ |fedora-review? | |needinfo?(timothee.floure@f | |nux.ch) --- Comment #2 from Jan Staněk <jstanek@xxxxxxxxxx> --- Thanks for the review! Based on the comment, I did some changes and tweaks, can I ask for re-review? Spec URL: https://copr-be.cloud.fedoraproject.org/results/jstanek/package-reviews/fedora-rawhide-x86_64/00868750-swaylock/swaylock.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/jstanek/package-reviews/fedora-rawhide-x86_64/00868750-swaylock/swaylock-1.3-1.fc31.src.rpm > Conflicts with the sway 0.x package, which will be updated soon. There is nothing to do about it. Well, beside adding an explicit conflict with sway < 1.0 ;) Implicit conflicts should not be allowed – see [1]. On which fedoras is the sway update planned? I should probably only request stable branches for those where the swaylock and sway can be actually installed next to each other. Also, while running a scratch review for myself, I run into issue with ownership of the directories for the completion scripts -- they should also be owned by the package ([2]). Be aware that this will generate shared directory ownership warning in `fedora-review`, but that one always has false positives :) I suggest deleting the listing of packages that also share the directories and verifying that the list looks sane. [1]: https://docs.fedoraproject.org/en-US/packaging-guidelines/Conflicts/#_splitting_packages [2]: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_the_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
