[Bug 1688851] Review Request: perl-Alien-ProtoBuf - Find Protocol Buffers library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1688851

Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Alien-ProtoBuf-0.08-1.fc31.noarch.rpm | sort | uniq
-c | grep -v rpmlib
      1 perl(Alien::Base)
      1 perl(Alien::ProtoBuf)
      1 perl(Data::Dumper)
      1 perl(Module::Build) >= 0.28
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(parent) 
      1 perl(strict)
      1 perl(warnings)
      1 pkgconfig(protobuf) = 0
Binary requires are almost Ok.
FIX: I didn't find any using of perl(Data::Dumper), please remove it.

$ rpm -qp --provides perl-Alien-ProtoBuf-0.08-1.fc31.noarch.rpm | sort | uniq
-c
      1 perl(Alien::ProtoBuf) = 0.08
      1 perl-Alien-ProtoBuf = 0.08-1.fc31
      1 perl(Alien::ProtoBuf::ConfigData)
      1 perl(Alien::ProtoBuf::Install::Files)
Binary provides are Ok.

$ rpmlint ./perl-Alien-ProtoBuf*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Please correct 'FIX' issue.

The package looks good.
Resolution: Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux