[Bug 1688075] Review Request: golang-github-yudai-golcs - Go Longest Common Subsequence

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1688075



--- Comment #4 from Nathan Scott <nathans@xxxxxxxxxx> ---
(In reply to Robert-André Mauchin from comment #2)
> [...]
> should be snapshotdate i.e. the day you made the snapshot not the day of the
> commit. 
> Also it is automated by the macros, it is set to the date you upload the
> archive to dist-git.

Ah excellent - thanks for these and all the other clues.  I've fixed 'em
up, and will upload new spec/srpm files shortly.

> > (most OK but i686 and armv7hl builds failing tests with ENOMEM - needs some
> > further investigation)
> 
> Please fill a bug with upstream for failure on 32bits arches. Or patch the
> tests so it doesn't try to allocate 100,000×100,000 int.

I've opened https://github.com/yudai/golcs/issues/3

I also attempted some different settings in the test code, but have found
reducing the allocation sizes to also be problematic.  The array must be
of certain size that it takes >1sec to process for the test to function.

Reducing sizes results in some passes, but the test fails intermittently.
I'll patch just this one timing-sensitive test out of the build for now,
leaving other tests in place, and see if upstream can fix the issue for
the next release.

cheers.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux