https://bugzilla.redhat.com/show_bug.cgi?id=1688084 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #4 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Not needed: %global commitdate 20150907 %global shortcommit %(c=%{commit}; echo ${c:0:7} It is automatically computed. - Release should start at 0.1 for pre-release: Release: 0.1%{?dist} - Add a dot at the end of the descriptions: %description %{summary}. %package devel Summary: %{summary} BuildArch: noarch %description devel %{summary}. - The changelog entry should reflect the computed release tag: * Wed Mar 13 2019 Nathan Scott <nathans@xxxxxxxxxx> - 0-0.1.20190313gitcb7f23e (the date needs to be changed to the day you upload the archive to dist-git) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
