https://bugzilla.redhat.com/show_bug.cgi?id=1688075 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags| |fedora-review? --- Comment #2 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - License ok - Latest version packaged - Conforms to Packaging Guidelines - %global commitdate 20170316 should be snapshotdate i.e. the day you made the snapshot not the day of the commit. Also it is automated by the macros, it is set to the date you upload the archive to dist-git. - the release field for a pre-release dev snapshot is not okay, it should start at 0.1: Release: 0.1%{?dist} - use a better description: %global common_description %{expand: A package to calculate LCS of slices.} […] %description %{common_description} %package devel Summary: %{summary} BuildArch: noarch %description devel %{common_description} (In reply to Nathan Scott from comment #1) > https://koji.fedoraproject.org/koji/taskinfo?taskID=33445301 > > (most OK but i686 and armv7hl builds failing tests with ENOMEM - needs some > further investigation) Please fill a bug with upstream for failure on 32bits arches. Or patch the tests so it doesn't try to allocate 100,000×100,000 int. - Don't mix tabs and spaces: golang-github-yudai-golcs.src:5: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 2) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
